Issues with MDQ AppModel attributes

[laurenwalker]

• [ ] In the default theme, I am getting an error:

  TypeError: Cannot read property '0' of undefined
  at n.getMdqScores (Stats.js?v=2.8.4:1380)
  at n.getAll (Stats.js?v=2.8.4:122)
  at n.render (StatsView.js?v=2.8.4:139)
  at n.renderMetrics (PortalMetricsView.js?v=2.8.4:156)
  at n.postRender (PortalMetricsView.js?v=2.8.4:171)
  at n.switchSection (PortalView.js?v=2.8.4:443)
  at n.handleSwitchSection (PortalView.js?v=2.8.4:462)
  at HTMLElement.dispatch (jquery-1.9.1.min.js?v=2.8.4:3)
  at HTMLElement.v.handle (jquery-1.9.1.min.js?v=2.8.4:3)

  I believe this is because there are AppModel attributes for the mdq features (e.g. mdqAggregatedSuiteIds) that are in the arctic and knb theme AppModel.js files, but I don't see them in the js/models/AppModel.js (default) AppModel.

• [ ] Why are there AppModel attributes that are listed as default attributes in the defaults object, but then they are set() during initialize() as a different name? They should just be listed in the defaults object. https://github.com/NCEAS/metacatui/blob/feature-portals-agu-demo/src/js/themes/arctic/models/AppModel.js#L390-L393

[gothub]

Fixed in commit 47787a6e27d2377e1a1908f217f4a633fd6706cb

Changes in this commit include:

• removing redundant definition of quality metrics attributes
• add needed definition for quality metrics to ./src/js/models/AppModel.js (default theme)
  • default theme uses FAIR Suite as dataset quality suite
  • default theme doesn't display quality metrics by default (requires attribute edit to change)
• inspect displayDatasetQualityMetrics attribute instead of mdqUrl to determine if quality metrics should be displayed