search

NCEAS / metacatui

MetacatUI: A client-side web interface for DataONE data repositories
https://nceas.github.io/metacatui
Apache License 2.0
42 stars 27 forks source link

Attribute info not resizing correctly #1272

Closed gothub closed 4 years ago

gothub commented 4 years ago

Here is a bug report from @mpsaloha (Mark Schildhauer

Attached are 3 screen shots showing what I take to be a bug with the Web UI on both DataONE and the Arctic Data Center, which is that at "intermediate display widths"-- details about attributes are relocated below (rather than to the side) of the Attribute listing. When the browser width is narrowed or widened, then the Attribute details are "properly" displayed to the right of the listing.

Here is a link to the data package where I discovered this issue, but it appears to hold for other (all?) data packages where attribute details are provided.

https://arcticdata.io/catalog/view/doi:10.18739/A28S4JP53

(Note that the images below show a narrow, medium and then wide browser window)

Narrow width- attribute details at side Medium width-- attribute details at bottom Wide width- attribute details at side
amoeba commented 4 years ago

Thanks for writing this up @gothub and for the screenshots. This appears similar to the closed issue #916 and the open issue #1029. @laurenwalker wrote up a fix in dfd4808d4d17c6c5569e36fc7a5b4657c93e54c1 to close #916. It looks like the fix went in 2.8.4 which is deployed at both search.dataone.org and arcticdata.io.

I can take this and look into it.

amoeba commented 4 years ago

Okay, can confirm the bug exists on the dev-2.9 branch.

amoeba commented 4 years ago

I tried commenting out the above the change from dfd4808d4d17c6c5569e36fc7a5b4657c93e54c1 to see what the effect would be and the bug appears to go away. @gothub would you have a sec to confirm by checking the deployment at https://neutral-cat.nceas.ucsb.edu/view/doi:10.18739/A28S4JP53 when you get a chance?

gothub commented 4 years ago

@amoeba I tried the neutral-cat link and the resizing works correctly, thx!

amoeba commented 4 years ago

Thanks for checking, @gothub!

Hey @laurenwalker, while my change seems to fix things, it'd be undoing your dfd4808d4d17c6c5569e36fc7a5b4657c93e54c1. I don't want to undo anything you were trying to do with that change so could you take a second look here and see if you're okay with changing this back?

amoeba commented 4 years ago

FYI the netural-cat demo has been switched out so the above link isn't an accurate representation of my patch.

amoeba commented 4 years ago

Hey @laurenwalker, I took another look at this just now and undoing https://github.com/NCEAS/metacatui/commit/dfd4808d4d17c6c5569e36fc7a5b4657c93e54c1 still works as far as I can see. c162a247075f8b079180fb5834fd4b5203a73000 is deployed at https://neutral-cat.nceas.ucsb.edu/view/urn:uuid:0a409765-7519-4bef-a04d-dd0bf352fd37. I can't get the attributes pane to jump below the list at any browser width.

Do you wanna take a look or shall I just close this and #1029?