Closed laurenwalker closed 4 years ago
Thanks Rushi! I reviewed your changes and I agree with this:
I just wanted to know your thoughts if we should keep it clean and trigger the navigate when we update the paths?
Since I was already looking at the code, I just went ahead and made the change while I was in there. So I think this ticket is good to go, however, could you do some quick testing on different browsers, especially IE/Edge? If that all looks good to go, then let's close this ticket. Yay!
Thank you!
Thank you for reviewing Lauren! I'll get started with testing this on Windows.
Hi @laurenwalker
/portals
.Here's the flow:
Case 1: when someone goes to
/profile/{nodeId}
user
or anode
profile./profile/{nodeId}
path to/portals/{nodeId}
; but we do not trigger the navigate. Commit: https://github.com/NCEAS/metacatui/commit/339c647c1ac678a05f7477da1d52eba1b1b888a5Case 2: when someone goes to
/portals/{nodeId}
nodeId
label to Portal ViewI just wanted to know your thoughts if we should keep it clean and trigger the navigate when we update the paths?
TODO: Once we have the user profiles migrated to the Portal View (#1336, #1337), we can update the router so that for the render of
/profile/{nodeId}
and/profile/{user}
we directly follow Case 2 and eliminate the use of UserView.