NCEAS / metacatui

MetacatUI: A client-side web interface for DataONE data repositories
https://nceas.github.io/metacatui
Apache License 2.0
41 stars 26 forks source link

Route MN profiles to new /portals URL #1350

Closed laurenwalker closed 4 years ago

rushirajnenuji commented 4 years ago

Hi @laurenwalker

Here's the flow:

Case 1: when someone goes to /profile/{nodeId}

Case 2: when someone goes to /portals/{nodeId}

I just wanted to know your thoughts if we should keep it clean and trigger the navigate when we update the paths?

TODO: Once we have the user profiles migrated to the Portal View (#1336, #1337), we can update the router so that for the render of /profile/{nodeId} and /profile/{user} we directly follow Case 2 and eliminate the use of UserView.

laurenwalker commented 4 years ago

Thanks Rushi! I reviewed your changes and I agree with this:

I just wanted to know your thoughts if we should keep it clean and trigger the navigate when we update the paths?

Since I was already looking at the code, I just went ahead and made the change while I was in there. So I think this ticket is good to go, however, could you do some quick testing on different browsers, especially IE/Edge? If that all looks good to go, then let's close this ticket. Yay!

Thank you!

rushirajnenuji commented 4 years ago

Thank you for reviewing Lauren! I'll get started with testing this on Windows.