NCEAS / metacatui

MetacatUI: A client-side web interface for DataONE data repositories
https://nceas.github.io/metacatui
Apache License 2.0
42 stars 27 forks source link

Use POST for all Solr queries #1998

Open laurenwalker opened 2 years ago

laurenwalker commented 2 years ago

Right now MetacatUI only uses POST for Solr queries when the query string is very long. I have noticed some long queries being missed, particularly when I am trying to view my profile while logged into an account that is in doens of groups. The long concatenation of usernames is too long but MetacatUI still sends it as a GET. It also is becoming somewhat tech debt to maintain both GET and POST.

We originally supported GET and POST simultaneously to give MetacatUI owners time to upgrade to Metacat 2.10.2, which supports POSTs. That was in March 2019, so given that it is three years later, I propose we switch to sending queries via POST only. This will be a breaking change for people that want to continue using Metacat 2.10.1 or earlier, but those people can still use MetacatUI 2.20.0 or earlier.

mbjones commented 2 years ago

Sounds good.