search

NCEAS / metacatui

MetacatUI: A client-side web interface for DataONE data repositories
https://nceas.github.io/metacatui
Apache License 2.0
42 stars 26 forks source link

Map Components Polish 2: Add top shadow #2354

Closed yvonnesjy closed 3 months ago

yvonnesjy commented 3 months ago

This adds a subtle shadow on top of the map to soften the transition from the top navigation bar to the map.

Before

image

After

image
robyngit commented 3 months ago

Tested this but then realized you've only set Ian as the reviewer, oopsie! Here is what I found:

yvonnesjy commented 3 months ago

The issue in https://github.com/NCEAS/metacatui/pull/2353 is included in these changes.

Hey yup, this branch is based on the 2353 branch (and all my styling changes are kinda based on each other now). In general, I name my initial commit for a new PR <issue name>: <change summary> and the followup commits Fixup: <change summary>. So when you're reviewing, you can select the last commit that doesn't start with Fixup and all the fixups that follow it.

The help panel screenshot includes this new feedback blurb

That was from https://github.com/NCEAS/metacatui/pull/2348/files and the screenshot with the feedback blurb actually existed in the repo, and was replaced by one without the blurb. I just thought it was an outdated screenshot cause I haven't seen blurb anywhere... but lmk if that's not the case😳

yvonnesjy commented 3 months ago

Ensure that the expanded layer panel doesn't overlap with the map in the Data Catalog View.

Rebased and this should be fixed now.