NCEAS / metacatui

MetacatUI: A client-side web interface for DataONE data repositories
https://nceas.github.io/metacatui
Apache License 2.0
41 stars 27 forks source link

Legend 1: Create Cesium widget container #2441

Closed yvonnesjy closed 3 months ago

yvonnesjy commented 3 months ago

This container is intended to be a parent for the map and all overlays (ex. legend, scale bar, etc). Reducing the top level container to just the panel and the map will help with the layout migration where we use the top-bottom layout. Design doc

If I don't get to migrating the scale bar, I created the tracking issue at: https://github.com/NCEAS/metacatui/issues/2440

ianguerin commented 3 months ago

Is there more functionality coming to the JS side of this in the future? Could this be accomplished with some small modifications to templates/maps/map.html?

yvonnesjy commented 3 months ago

Is there more functionality coming to the JS side of this in the future? Could this be accomplished with some small modifications to templates/maps/map.html?

good qs. this component will indeed be simple with not much actual logic going on. I technically can just update MapView.js, but it feels more correct to me to organize the views a little. Unless there's a strong reason not to, I think one extra container js doesn't hurt.