search

NCEAS / metacatui

MetacatUI: A client-side web interface for DataONE data repositories
https://nceas.github.io/metacatui
Apache License 2.0
42 stars 24 forks source link

Legend 4: Render categorical palette #2445

Closed yvonnesjy closed 2 weeks ago

robyngit commented 2 weeks ago

@yvonnesjy there are some tests failing other than the eslint errors, see https://github.com/NCEAS/metacatui/actions/runs/9556159324/job/26377186438?pr=2445.

Prettier formatting needed for:

And one unit test is not passing:

FAILS:  1
PASSES: 553
Failed Tests: 
-------------

[1]: LegendContainerView Test Suite
     > toggleExpanded
     > AssertionError: expected false to be true
    at Context.<anonymous> (js/specs/unit/views/maps/legend/LegendContainerView.spec.js?v=undefined:99:49)

This is easy to miss if we're ignoring the ESlint failures. Maybe we need to change the github action in someway to make it clearer which have failed and which are passing.

yvonnesjy commented 2 weeks ago

Ah thanks for catching! Fixed. Is there a way to only mark eslint failure as warning for now?

I also pushed a commit that incorporates the label fixes