search

NCEAS / metacatui

MetacatUI: A client-side web interface for DataONE data repositories
https://nceas.github.io/metacatui
Apache License 2.0
42 stars 28 forks source link

Able to Save/Submit With Taxa Errors #328

Open ThomasThelen opened 7 years ago

ThomasThelen commented 7 years ago

We're able to save data sets that have errors in the taxa section. This may be related to #316 and #312 .

Case 1: User submits a new data set and forgets to fill out the 'Order'. We throw an error like we're supposed to (see image below) however, we're still able to successfully submit the data. The resulting data package does not include the 'Order'.

screen shot 2017-11-01 at 10 29 53 am

Case 2: User edits an existing data set and forgets to fill out 'Order'. Let's say that the user realizes their 'Order' did not get saved, so they open the data package from Case 1 up (image below).

screen shot 2017-11-01 at 10 33 54 am

They decide to add 'Order', but again, forget to fill out the value. The user is presented with the error like before, but can still submit the data.

screen shot 2017-11-01 at 10 34 49 am
laurenwalker commented 7 years ago

I guess this could be seen as a bug or a feature. The question is, do we want to require users to remove or complete an incomplete taxa row before they can submit the package?