search

NCEAS / metacatui

MetacatUI: A client-side web interface for DataONE data repositories
https://nceas.github.io/metacatui
Apache License 2.0
42 stars 28 forks source link

Data Properties are Offset #379

Open ThomasThelen opened 7 years ago

ThomasThelen commented 7 years ago

screen shot 2017-11-17 at 10 52 01 am

screen shot 2017-11-17 at 10 56 47 am

To reproduce, navigate to a data set and scroll down to look at the properties.

Reproduced on macOS High Sierra 10.13.1 Chrome Version 62.0.3202.62 Safari 11.0.1 Firefox 57.0

amoeba commented 7 years ago

Nice work on the detailed bug report! I've noticed this behavior too.

The HTML in question is actually produced by Metacat and MetcatUI is just rendering it without modification from Metacat's View Service. Do you have access to create new Issues on https://projects.ecoinformatics.org/ecoinfo/projects/metacat-5 and would you be interested in filing this there and closing this Issue? The fix would involve changing the underlying eml-2 XSLT.

ThomasThelen commented 7 years ago

Moved to Metacat, issue number 7229.

laurenwalker commented 7 years ago

It may be a MetacatUI issue if it is offset because of CSS and not the HTML. It will require some investigation to determine which needs to be fixed (HTML in Metacat or CSS in MetacatUI). So I'll reopen until that investigation is done.

robyngit commented 1 year ago

Just a note for when this issue is worked on in the future: Here is where the request is created and sent to Metacat, and the resulting HTML response is inserted in the MetadataView. It's inserted into the div with the ID #metadata-container in the templates/metadata/metadata.html template.

artntek commented 1 year ago

Verified that Metacat is still sending HTML (created by xsl stylesheets), but after discussing with @robyngit, I'm closing metacat issue #1212, since it is the css styling and not the HTML which causes the misalignment, AFAICT. The html that metacat sends back is pretty clean & minimal -- here's an example:

<div class="control-group">
    <label class="control-label">Individual</label>
    <div class="controls">
        <b> Anne Ecologist</b>
    </div>
</div>