NCEAS / metacatui

MetacatUI: A client-side web interface for DataONE data repositories
https://nceas.github.io/metacatui
Apache License 2.0
42 stars 27 forks source link

Update unordered categories definition #865

Closed dmullen17 closed 4 years ago

dmullen17 commented 5 years ago

I've noticed that a majority of submitters don't realize that the following category applies when they use integers to represent their categories.

Unordered categories
The values of this attribute are unordered categories or classifications. Example: male or female

I think it would be a good idea to expand on this a bit more so they make the connection. For instance:

The values of this attribute are unordered categories or classifications.  Example: 1. male or female 2. 1 or 2 where 1 and 2 represent groups.

I'm sure the above could be improved on, just an example

amoeba commented 4 years ago

Having a go at this now.

amoeba commented 4 years ago

Came up with a change to both unordered and ordered:

Screen Shot 2020-04-17 at 11 05 45 AM

Open to minor tweaks anyone has. Feel free to commit them up top of comment here. Otherwise, ready for merge.

laurenwalker commented 4 years ago

Looks good, my minor suggestion is to put an "or" before "site codes":

Examples: Sex (Male, Female), or site codes coded as letters or numbers (e.g., 1, 2, 3 or A, B, C).

amoeba commented 4 years ago

Sounds good, thanks! Updated in https://github.com/NCEAS/metacatui/commit/d10bd2e3162418f7a684b87665969158436db9c4.

I'll go ahead and close this now. If anyone has any further suggestions please comment here and we can reopen and address them.