resource.accessControlRules.present

NCEAS / metadig-checks

MetaDIG suites and checks for data and metadata improvement and guidance.

Apache License 2.0

9 stars 9 forks source link

resource.accessControlRules.present #29

Closed gothub closed 4 years ago

gothub commented 5 years ago

Description

If metadata and entities are not public, do access control rules exist that allow access to a defined set of users.

Priority

FAIR: Required

Issues

Procedure

Check the DataONE system metadata for the metadata object. If public access is set, the check passes. If public access is absent, but other users are allowed read, the check passes.

gothub commented 5 years ago

This is checking the XPaths:

      /eml/dataset/intellectualRights |
      /*/identificationInfo/*/resourceConstraints/MD_LegalConstraints/accessConstraints

is this what we want for this check? What is the concept being checked here and how is it different than https://github.com/NCEAS/metadig-checks/issues/80

gothub commented 4 years ago

Update this check to look at the sysmeta for the metadata object and check

if public access is not allowed, are other groups specified?
if public access is allowed, then this check should pass

The metadata itself will not be checked

gothub commented 4 years ago

This check was refactored to comply with the 'Procedure' description above. These changes were made in commit 4bce6bbeedab097df6818d6eaa0141bb5a949a25