entity.attributeEnumeratedDomains.present giving false positive

NCEAS / metadig-checks

MetaDIG suites and checks for data and metadata improvement and guidance.

Apache License 2.0

8 stars 9 forks source link

entity.attributeEnumeratedDomains.present giving false positive #413

Closed gothub closed 3 years ago

gothub commented 3 years ago

The check entity.attributeEnumeratedDomains.present gives a "SUCCESS" status for the DataCite 4.x 'full' document, when instead it should fail.

jeanetteclark commented 3 years ago

It looks like in the check code that the case of what to do when which(!is.na(enumerated_domains)) returns an empty vector, so that might be where this is coming from

gothub commented 3 years ago

Fixed in commit 43c1e5f333343cef4a592669f0eff569f846abf9