NCEAS / metadig-engine

MetaDig Engine: multi-dialect metadata assessment engine
7 stars 5 forks source link

#327 rabbitmq connections and #350 track run status #353

Closed jeanetteclark closed 1 year ago

jeanetteclark commented 1 year ago

In this PR:

Feedback appreciated - I'm especially not that happy with the pattern for the MonitorJob code that retrieves the object and its system metadata, would love some suggestions there

jeanetteclark commented 1 year ago

Thanks for the review @mbjones - I got most items fixed. Can we discuss the stuff surrounding exceptions more broadly on the backend call tomorrow?

mbjones commented 1 year ago

Sounds like a good plan for tomorrow's call.

jeanetteclark commented 1 year ago

Thanks for the review @mbjones and @artntek. I think at this point I've addressed your comments and fixed up all of the exceptions (in this part of the code anyway). Would you mind having a look again and with your ok we can merge and start moving towards the release