Closed jeanetteclark closed 1 year ago
Thanks for the review @mbjones - I got most items fixed. Can we discuss the stuff surrounding exceptions more broadly on the backend call tomorrow?
Sounds like a good plan for tomorrow's call.
Thanks for the review @mbjones and @artntek. I think at this point I've addressed your comments and fixed up all of the exceptions (in this part of the code anyway). Would you mind having a look again and with your ok we can merge and start moving towards the release
In this PR:
monitor
method to the Controller which runsMonitorJob
metadig.properties
runs
table that have a status of processing and a timestamp older than 24 hoursgetProcessing
)runs
table,runCount
, and add it to theRun
modelruns
table with status processing, and ack the message from the Controller afterwards, before running checksgetProcessing
method using the in memory store (not that realistic for what we will actually use it for, sadly)Feedback appreciated - I'm especially not that happy with the pattern for the
MonitorJob
code that retrieves the object and its system metadata, would love some suggestions there