Closed mbjones closed 1 year ago
Yeah, definitely on the right track here. So with this system of entity.subentity.checktype
the checks we have now are:
data.table-text-delimited.well-formed (#2) data.format.congruent (#9)
upcoming checks to write would be:
data.text-encoding.valid (#12) data.text-encoding.congruent (#12) data.attribute-names.congruent (#3)
Any concern about deviating from camel case in the subentity
slot for kebab case? I'm guessing the camel case was to match the corresponding EML slots?
existing checks have been renamed
@jeanetteclark Peter and I noted that, as the number of checks grew in metadig, they were hard to find and understand. So we shifted to a check naming pattern of
entity.subentity.checktype
, whereentity
is the kind of resource being checked,subentity
is the component of that entity being checked, andchecktype
was a short name for the kind of check being run. We tried to be consistent with our checktypes across entities (e.g.,present
andresolvable
had the same meaning across different entity types). This allows checks on similar entities to sort together, and for one to find similar kinds of checks across different entities. For example, the following metadata check names are fairly sortable and interpretable:resource refers to the thing being described by a metadata document (e.g., a Dataset), while
metadata
refers to the metadata about that resource. I'm not sure that distinction really holds up to scrutiny, open to discussion.It would be good if the data checks followed a similar convention. Maybe something like:
In this case,
data
is a stand-in for the individual data objects that might be contained within a Dataset. Byvalid
I mean that the bytes we find on disk correspond to the corresponding specification. Bycongruent
I mean that what we find on disk matches what was claimed in the metadata. Lot's of ways to structure this, but I think it would be good to pick a decent convention to get started (which will also make renaming checks easier if we decide to do so later). Thoughts welcome.