NCEAS / morpho

Morpho metadata editor
GNU General Public License v2.0
3 stars 1 forks source link

morpho creates <keyword> elements out of keywordType attribute content #880

Closed mbjones closed 6 years ago

mbjones commented 6 years ago

Author Name: Margaret O'Brien (Margaret O'Brien) Original Redmine Issue: 4657, https://projects.ecoinformatics.org/ecoinfo/issues/4657 Original Date: 2010-01-08 Original Assignee: ben leinfelder


the element has an optional attribute keywordType, as in this snippet from knb-lter-sbc.17.12

Santa Barbara Coastal LTER

EML created by Morpho does not include this attribute, but when Morpho encounters one, it takes the attribute content and moves it to a keyword element, yielding a node like this (knb-lter-sbc.17.13):

theme Santa Barbara Coastal theme LTER

So now we have extra erroneous keywords, and no keywordType attributes. Morpho seems to do this as soon as it reads the EML in, since the extra keywords show up immediately.

Note: this data set is still EML201, and so was was edited with Morpho 1.6.1. I confirmed the behavior with Morpho 1.7 and a local test dataset.

mbjones commented 6 years ago

Original Redmine Comment Author Name: ben leinfelder (ben leinfelder) Original Date: 2010-01-08T22:39:35Z


is there a docid that hasn't yet been corrected?

mbjones commented 6 years ago

Original Redmine Comment Author Name: ben leinfelder (ben leinfelder) Original Date: 2010-01-09T00:00:04Z


simple solutions: -pop up the tree editor when we encounter keywordType attributes -remove them and carry one with the wizard page

harder: -ignore them, but keep them with the keyword they correspond to. but if you can't see the keywordType, then and you edit the text of a keyword do you keep the same keywordType?

mbjones commented 6 years ago

Original Redmine Comment Author Name: Margaret O'Brien (Margaret O'Brien) Original Date: 2010-01-09T00:31:56Z


Good point, Ben - that if Morpho ignore the keywordType element, how does the user know an edited keyword still has the same type.

So, 2 things:

  1. this suggests one of the simple fixes. The general morpho user will not want to encounter the tree editor, so dropping the keywordType attribute is preferred. Generally, I loathe dropping information, but in this case it might represent not-so-usable information ... (see note 2)

  2. this reminds me of a recent discussion among some EML authors, about the EML keyword nodes. In general, it was thought that the current spec -- a restrictive keywordType list for the keyword itself but no id attribute for the keywordSet -- was limiting and not particularly usable.

So dropping the keywordType attribute is acceptable. Those people with applications making use of it cannot be using morpho-originated documents anyway.

mbjones commented 6 years ago

Original Redmine Comment Author Name: ben leinfelder (ben leinfelder) Original Date: 2010-01-12T18:32:22Z


the keywordType attribute will now be preserved behind the scenes when editing with the wizard interface.

mbjones commented 6 years ago

Original Redmine Comment Author Name: Redmine Admin (Redmine Admin) Original Date: 2013-03-27T21:27:38Z


Original Bugzilla ID was 4657