NCEAS / morpho

Morpho metadata editor
GNU General Public License v2.0
3 stars 1 forks source link

Incorrectly rendered column data #918

Closed mbjones closed 6 years ago

mbjones commented 6 years ago

Author Name: Darren Hardy (Darren Hardy) Original Redmine Issue: 5257, https://projects.ecoinformatics.org/ecoinfo/issues/5257 Original Date: 2010-12-15 Original Assignee: ben leinfelder


Morpho doesn't seem to handle escaped quotes correctly in some CSV files.

In this example (from the attached CSV file):

"Fort Jefferson, FL",USA "Kealakakua, HI",USA

Morpho renders the the columns incorrectly (uses 3 columns rather than 2).

It may be a problem with the specific EML for this example, but it looks clean to me. The docid is pisco_smr_synthesis.1.3 and the data table is called "pisco_smr_studylist.csv".

This is running Morpho 1.9 on MacOS 10.6.

mbjones commented 6 years ago

Original Redmine Comment Author Name: Darren Hardy (Darren Hardy) Original Date: 2010-12-15T21:36:29Z


Morpho 1.9 on Windows7 also renders the data table incorrectly.

mbjones commented 6 years ago

Original Redmine Comment Author Name: Matt Jones (Matt Jones) Original Date: 2010-12-15T22:07:22Z


This is probably just a shortcoming in our home-grown CSV parser. Since we developed this, effective CSV libraries have arisen for Java, and we could probably easily incorporate one of those. Might want to explore using, e.g., JavaCSV (http://sourceforge.net/projects/javacsv/).

mbjones commented 6 years ago

Original Redmine Comment Author Name: ben leinfelder (ben leinfelder) Original Date: 2010-12-15T22:45:40Z


there is a bug for this already. I've looked into it briefly but it did not make it into the 1.9.0 release

mbjones commented 6 years ago

Original Redmine Comment Author Name: ben leinfelder (ben leinfelder) Original Date: 2010-12-16T06:26:44Z


I checked that the data columns for pisco_smr_synthesis.1.3 were rendering with my new change- and they are

mbjones commented 6 years ago

Original Redmine Comment Author Name: Redmine Admin (Redmine Admin) Original Date: 2013-03-27T21:29:47Z


Original Bugzilla ID was 5257