search

NCEAS / morpho

Morpho metadata editor
GNU General Public License v2.0
3 stars 1 forks source link

Morpho revision handling is fragile #945

Closed mbjones closed 6 years ago

mbjones commented 6 years ago

Author Name: ben leinfelder (ben leinfelder) Original Redmine Issue: 5758, https://projects.ecoinformatics.org/ecoinfo/issues/5758 Original Date: 2012-12-03 Original Assignee: Jing Tao

A few times in the past I've had trouble with the local-revisions file being unparsable by the apache config library. When I look at the content it is valid XML and looks fine. Eventually (after a few restarts of Morpho) I could get it to read the file correctly.

However, I did this again today and hadn't fully shutdown my first Morpho instance and then with two instances running I quit one then the next one. On start up the file was empty. My file was: /Users/leinfelder/.morpho2/profiles/leinfelder/local-revisions.properties

This error seems to crop up when I "terminate" morpho abruptly (like form eclipse when it can't hot swap my latest changes). I think we need to be able to recover from unplanned System.exits no matter what.

mbjones commented 6 years ago

Original Redmine Comment Author Name: Jing Tao (Jing Tao) Original Date: 2012-12-15T00:19:26Z

I can't duplicate the bug. But I did take a look at the code and found some nested synchronized code. The code was removed and hopely the issue has been fixed. Ben, please write a comment when you see it happen again.

mbjones commented 6 years ago

Original Redmine Comment Author Name: Jing Tao (Jing Tao) Original Date: 2012-12-20T22:19:41Z

I dug around the code again and found there were some code to modify the revision property during the initial method (reading the revision property file). So both reading and writing happened simultaneously. I removed this part. Hope the issue has been fixed.

mbjones commented 6 years ago

Original Redmine Comment Author Name: Jing Tao (Jing Tao) Original Date: 2013-01-11T22:42:37Z

After the change, morpho has worked very well for me. I am closing the bug. If there is any problem happen again, we can reopen this bug.

mbjones commented 6 years ago

Original Redmine Comment Author Name: Redmine Admin (Redmine Admin) Original Date: 2013-03-27T21:31:35Z

Original Bugzilla ID was 5758