NCEAS / sasap-training

Training agendas and materials for open science tools for SASAP
https://nceas.github.io/sasap-training
8 stars 6 forks source link

Chapter 9: Cowplot package #17

Closed cornejotux closed 6 years ago

cornejotux commented 6 years ago

chapter 9, numeral 9.11 we use the package cowplot but this is not included in the packages required/installed at the beginning or is a dependence, so when

suppressPackageStartupMessages({
  library(cowplot)

})
plot_grid(p1, p2, align = "hv", ncol = 1)

this fails:

Error in library(cowplot) : there is no package called ‘cowplot’

Should we add id on Chapter 3, numeral 3.2.2 ?

amoeba commented 6 years ago

Probably my mistake. Sorry! Also: I'd teach this section with https://github.com/thomasp85/patchwork now that patchwork is the defacto way to compose ggplot plots. What do you think about switching that out?

Might be possible to just remove the gridExtra (which is not that good for users IMHO) and cowplot in one well fell swoop.

mbjones commented 6 years ago

patchwork looks great to me in theory. Nice package. The repo was only created 6 months ago... How well tested is it in practice? De facto for what group of people? Does it work seamlessly on Windows?

amoeba commented 6 years ago

Good points! I actually missed this earlier: It's not on CRAN so maybe this isn't a great update.

How well tested is it in practice?

Not sure. I've only used it superficially but with how popular it is I'd guess it's pretty well tested. I think 679 stars is a lot for an R package.

De facto for what group of people?

For the small set of users who aggressively follow the rstats/ropensci community. I'd suspect the average researcher hasn't heard of it. But that also applies to gridExtra and cowplot so I think it's fine. I say de facto mostly because gridExtra isn't a good-enough multi-panel plot solution and cowplot is a meta package whereas patchwork is a dedicated package.

Does it work seamlessly on Windows?

Good question! I haven't tested.

mbjones commented 6 years ago

Still looks super promising to me. But I think we'd need to test before going live during a training.

jeanetteclark commented 6 years ago

any update on this @cornejotux? will be relevant for the pre-req email

cornejotux commented 6 years ago

No, this is on the .com/nceas SASAP-trining repo.

On Wed, May 9, 2018 at 10:00 AM Jeanette Clark notifications@github.com wrote:

any update on this @cornejotux https://github.com/cornejotux? will be relevant for the pre-req email

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/NCEAS/sasap-training/issues/17#issuecomment-387806400, or mute the thread https://github.com/notifications/unsubscribe-auth/AJvVkoBHa4v5-0FC2Scffmo8DmaHWxAXks5twyCbgaJpZM4TzXkQ .

--

Jorge F. Cornejo-Donoso PhD Marine Science cornejotux@gmail.com http://www.jorgecornejo.net http://www.surforacle.net

jeanetteclark commented 6 years ago

okay, well we didn't get this far when we taught this last time. We need to either:

jeanetteclark commented 6 years ago

chose the second option