Closed Nazrath10R closed 5 years ago
took a bit of time, but I have made the changes.
Default page size is 300 now, anything with more than 9 data samples, has a scroll bar
Limitations: max size of 400px has been added, which means if you want to see all rows expanded on main page, instead have to scroll within that 400px window. (I don't think this really is a big issue)
we can increase the size of the window to something a bit larger too.
made it so that if you change the pagination at all, it makes the whole table large without the scroll bar.
If they choose 300, it shows the scrollbar again
to do: possibly also add scrollbar to the variants section?
looks better in the pic. If there's a scroll bar we dont need the next buttons and pagination inside at all i guess
doubt we'd have THAT many variants in a single sample to require a scroll bar. Would be great as a result if there was though lol
Im leaving the pagination, as if they set size to 200 for example, it will display it larger like this:. https://puu.sh/B6S6T/f503b4eb5c.png
Also while working on the table, i've fixed the search for browse/tissuename
Will update server later today to reflect the changes
Server Updated, have a play around with the table, settings different page sizes
and also the search function on/browse/breast
I see what you did. Got mixed feelings. I like having it at 300 and different sizes. Perhaps could ask users what they think
They may want it all on one page.
So what options?
Option 1: leave at 300 and remove all pagination from that sub-table
or Option 2 (current): have multiple pagination options, 300 means all data + scrollable, while the rest simply displays all the data on the main page
https://puu.sh/B6SU5/68985deceb.png
without pagination
I am divided. I think option 1 is neater and option 2 offers more flexibility. Leave it at option 2 and we can get users to vote for their preference
Oh yeah, not sure if I mentioned it already, I fixed the search filter issue on /browse/breast earlier in the week
It doesn't mess up anymore.
full fuzzy searching has been implemented.
Server not updated yet.
amazeballs
Search fixed, now does a "contains" match
is it possible (effort) to change the dataset expanded view into an expansion with a scrollbar instead of a second pagination?