Epic 2293 - 'Nice to have' issues

[jose-west]

Originally posted by Vassil on Slack on the 4th and 6th of October 2019

I am at the training event. A few "nice to have" low hanging fruits:

• [x] add has a bio filter to the advanced search for people (see #2305)
• [x] add page tabs to the bottom of lists, not only the top (I think a search result for reports has them at the top only) (see ##2309)
• [x] in advanced search for dates, have an option of exact date, maybe call it on day of or simply on
• [x] clicking on the ANET logo should clear the search text (see #2313)
• [x] (super minor) the print version of the rollup has links to /reports/uuid/min but they do not render
• [x] error while emailing rollup: Internal server error - Validation error of type SubSelectionNotAllowed. Sub selection not allowed on leaf type int of field emailRollup @ 'emailRollup'

Some other observations that require a bit more thought:

• [x] having a user type while a report is saving seem to have eaten up a few words. Also, the toast for saved reports is a bit distracting. We need to come up with some more subtle feedback for autosave. I suggest a save draft that changes to a green draft saved indicator (see #2306)
• [ ] we need to revisit what is stored in the state of each "page" and when is this state reset. For example, users do a search, then click to calendar, go to a specific month, then day view of one day, then select one of the reports. They read the report, then go back to read another one of that day, but they have to re-navigate again. I suggest to go over the UI and define for each page which state properties are reset and how depending on navigation path. Might be a good opportunity now that we have hooks. (see #2307)

Related to the rollup usability:

• [ ] Does it make sense to move the advisor organization / principal organization button to the Chart by org widget? it would free up some real estate for the rollup. I suggest to try to put it in the title - i.e. Rollup by [advisor ▼] organization where [advisor ▼] is a dropdown.

• [ ] rollup -> we should add an indicator of which org is selected and a way to go up. Maybe something like Rollup by [advisor ▼] organization for organization [org_xyz ▼]▲ where [org_xyz ▼] brings an org selector and ▲ navigates directly to parent

• [x] I suggest to place the mosaic layout toolbar on the same level of the title, to the right of it, and also to remove the redundant title it has.

• [ ] I suggest to reduce the padding of the mosaic window

• [ ] everybody gets stuck at having to use ctrl+wheel for the map. I did not see a single person using ctrl. I suggest to switch back to just wheel. The downside is, as discussed before, that they will have to use the scrollbar if they want to scroll down in that case. I think it the lesser of the two evils, and that we can help that with a bit more context navigation help in the left nav bar and/or a fancier scrolling mechanism.

• [ ] I saw a person reading a report, and attempting to scroll with the wheel while in the nav pane. Not too sure about that, we could make wheel movements in the unused space (if any) under the nav bar move the main pane.

Related to the search functionality:

• [x] Another one which is very confusing to users: they click on add filters, Then select reports, and then click on Search -> there is no search happening. I understand why it is confusing - they have followed the UI, selected something they want to see (reports), clicked on search and they get an error. At this point, the UI even says "add another filter" which implies that they have added a filter already. ~I propose to have that result into basically returning all reports (or other objects)~ the alternative is to give some feedback that they have not completed their filter selection
• [x] Searching with not filled filters
• I search on reports, add the author filter, but don't fill this in
• I click search => get lots of results
• I do save search
• I go to homepage, select the just saved search and under the saved searches I see the results preview for it => as expected
• I click on show search => goes to the search page and displays "You did not enter any search criteria" => I would expect to have the same search results

[gjvoosten]

• [ ] Searching with not filled filters
• I search on reports, add the author filter, but don't fill this in
• I click search => get lots of results
• I do save search
• I go to homepage, select the just saved search and under the saved searches I see the results preview for it => as expected
• I click on show search => goes to the search page and displays "You did not enter any search criteria" => I would expect to have the same search results

@vassil This one is caused by JSON.stringify({authorUuid: undefined}) returning {} because JSON doesn't have undefined. A solution might be to call: JSON.stringify(obj, (k, v) => v === undefined ? null : v) (change undefined values into null), but we need to investigate if that has any side effects.

@vassil Edit: yes, it does. Search filter deserialization currently does at some point: if (query[queryKey]) { which means null filter values get ignored. We could naively change that to something like if (queryKey in query) {, but that will eventually fail because the AdvancedSelectFilter deserialization will make a GraphQL request for a Person with uuid: null, which fails because the uuid parameter is non-nullable ("graphql.execution.NonNullableValueCoercedAsNullException: Field 'uuid' of variable 'uuid' has coerced Null value for NonNull type 'String!'"). You might think that changing that to be nullable would help, but then PersonResource::getByUuid will throw new WebApplicationException("Person not found", Status.NOT_FOUND). You're in a maze of twisty little passages…