search

NCI-Agency / anet

Advisor Network
MIT License
23 stars 11 forks source link

Replace hopscotch #3018

Open VassilIordanov opened 4 years ago

VassilIordanov commented 4 years ago

Hopscotch is unmaintained

Proposed solution Replace with react-joyride or reactour (careful with dependency baggage)

Additional context Consider a better placement for steps (in the actual code?) Also, consider a "What's new" tour

gjvoosten commented 4 years ago

See https://github.com/NCI-Agency/anet/tree/GH-3018-replace-hopscotch for a proof-of-concept replacing hopscotch with react-joyride.

Note that this has some problems, as can be seen when going through the "new report" tour: at some point, the 'next step' pop-up goes off-screen (doesn't scroll into view), and there's no way to scroll manually. The current hopscotch version has slightly different problems: at some point, the 'next step' pop-up will point to a blank screen. Both are quite possibly due to our (fixed, flexbox) layout, so that is something that would need to be addressed in either case.