search

NCIEVS / nci-protege5

evs umbrella project for protege 5-based editing software
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Batch Load Allows Duplicate Concept Names - 4.0.0 Client #555

Closed singhik closed 2 years ago

singhik commented 2 years ago

Issue :

Editor used the attached load file to create concepts that all had the same name. In theory, the GUI should not create new concepts with an existing name and the editor is supposed to get a Warning about duplicate names and create them manually. Even during manual creation, the editor needs to specify a unique name and modify it later.

Batch Load allows duplicate concept names. Manual creation works fine and does not allow duplicate Concept names.

Logs and sample batch files in Email with Subject : Protege Operation Error Details & Logs 06/13/2022 14:38:30 TinyBubbleTrouble.txt

fragosog commented 2 years ago

To clarify a bit, at the time of the batch, there weren't any duplicates in the vocabulary. The duplicates were only in the input file. This test would also fail in production.

singhik commented 2 years ago

@fragosog : Hi, i believe the ask from editors is to not allow duplicates as part of Batch file loads itself , Its like adding an extra assertion after each record is processed to validate if Preferred Name is unique or not from the supplied inputs .

singhik commented 2 years ago

Tested on 4.1.0-dev1 build client and works fine. Duplicate concept names in a batch file won't be allowed to process for Batch Load.