Improve logging on curator crashes

[bdionne]

When curator crashes due to bad data that leaks in ( .eg. #557), if possible log the class is being classified to enable modelers to review terminology and possibly fix

[singhik]

@bdionne @Fragosog: Hi, not sure how to insert bad data in the Thesaurus for the curator to catch post classification ? Is it a Unit Test only ticket ?

[fragosog]

Hi @singhik , Don't remember all the details, I think this is just more logging to catch errors (@bdionne ?). I think one item driving this was that things could be modified in a batch edit, as opposed to a gui edit where things are caught at edit time. So at least add more logging to see when/how things can go through. I can only suggest to go to the Entities tab and do some bad edits there, a) a class treed under two classes that are disjoint, e.g. "test class" treed under "anatomy" and "gene", b) add a restriction on a class where the filler value is outside the range of the object property, e.g. "test class 2" treed somewhere under "gene" with the role "participates_in_process" "liver". These two should produce unsatisfiable classes. And c) tree "test class 3" under its parent as well as under a grandparent. This one won't result in a classification error but I think we are logging it.

[bdionne]

Hi, not sure how to insert bad data in the Thesaurus for the curator to catch post classification ? - @singhik

You can disable all the curator checks and then make edits that violate these. They will then show up as inconsistencies in the inferences panel and/or will be logged

[singhik]

@bdionne @fragosog : Hi, Treeing a concept under its parent and Grandparent, neither gets classified as an Error nor gets logged in Protege Logs ?

Protege Status Call 1/5/2023 : This Scenario won't get logged cause its not an error, only errors are getting logged. hence it can be closed

[singhik]

Fixed and Tested on 4.2.0-dev1 client