NCIEVS / nci-protege5

evs umbrella project for protege 5-based editing software
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Add and Edit Not Working On Dual Edit Panels #563

Closed singhik closed 1 year ago

singhik commented 1 year ago

@bdionne @fragosog :

Steps to reproduce :

Create a concept image

Navigate to Dual Edit Panel and perform any operation f.e. Copy

image

Try to Add or Edit any of the Complex properties using + or / buttons in the Pane

image

Edit Fails and does not edit the concept :

image

Try to Add a Complex Property :

image

Add also fails and does not add the pty to the concept :

image

Delete works sometimes and sometimes does not

bdionne commented 1 year ago

This needs to be triaged better. I tried the obvious scenario based on these screenshots and I can't reproduce this.

I reviewed the codes and commits for this release and see nothing related, perhaps this has been here a while.

Was there a log for this with any exceptions in it?

There are several ways to do this operation, drag/drop, menu selection. Could we have a more detailed enumeration of the steps.

Does this reproduce readily? If possible maybe you can demo it at our weekly status.

I also tried loading the full thesaurus and have no problem with that either.

singhik commented 1 year ago

@bdionne : Yes, it is reproducible, you can try the Project that i have used. I have put detailed step by step operations with screen shots for each step , not sure what more details are needed or can be added.

bdionne commented 1 year ago

Yes, it is reproducible, you can try the Project that i have used.

Great! So I should be able to sort it out. I don't have access to your projects and server, and so have to reproduce issue locally

I have put detailed step by step operations with screen shots for each step , not sure what more details are needed or can be added

Did you use drag and drop or did you execute the clone from a right click on the navigation pane?

Is this a project that uses \ rather than # in the namespace?

Was the id used a manager, modeler, both?

Is there a log file?

I've tried what I think is the exact scenario in your screenshots, using a recent copy of Thesaurus, and it doesn't reproduce.

Thanks, I'll go over it with Gilberto at our weekly next Monday. If it's readily reproducible he can triage it with me.

singhik commented 1 year ago

@bdionne : I used drag and drop to input the concepts in the dual edit panel and then used Add,Edit,Delete buttons for Complex properties (as in the screenprints above) .

Yes, it is a project that uses \ in the namespace .

I used Manager Role .

Log file attached . [Uploading Logs.txt…]()

bdionne commented 1 year ago

Yes, it is a project that uses \ in the namespace .

I see, this is likely the culprit, it's new

Log file attached .

@singhik there's no file attached here, bad link?

singhik commented 1 year ago

@bdionne : Pfa, log files, Logs.txt

fragosog commented 1 year ago

The "/" project was built with "thesaurus-trimmed-45K-slash.owl.zip", in the nci-protege5/data directory.

bdionne commented 1 year ago

I see the issue, it shows up in the log.

The protege client is configured to use # instead of / so when you create new classes the # is used. This results in a mix of both in the same ontology.

If you change to / and restart the problem goes away.

bdionne commented 1 year ago

Per our conversation yesterday, QA to verify this is a configuration issue

singhik commented 1 year ago

@bdionne : Hi Bob, It's still failing and have tried several iterations , below are the steps with screenprints :

Preferences ,showing the Followed by setting : image

Created two concepts 'Test1' and 'Test2'. doing Dual Edits :

image

Trying to Edit or Add Complex properties using buttons , but unable to perform, only Delete option works :

image

image

image

image

Logs are attached for reference :

Logs.txt

bdionne commented 1 year ago

@singhik

I believe the issue is that you have the # and / mixed up still. Are you still using the test classes you created before? Is this still the project that uses / ?

I'm pretty sure this is the issue because I can see the exact same exceptions locally if I confuse those IRIs. In order to further triage this I will need the following:

With this info I can look into this further. This issue is really part of #490

Thank you.

@fragosog We should discuss #490 further. If we're going to allow the changing of IRIs in the preferences maybe we should evaluate what it takes to allow mixed usage in the same ontology. As you can see, it's already causing lots of confusion for users, and once the content is messed up it continues to be a problem.

singhik commented 1 year ago

@bdionne :

IRIs of the two edit classes (Created them afresh, not from before in multiple iterations):

http://ncicb.nci.nih.gov/xml/owl/EVS/Thesaurus.owl#C1000012 & http://ncicb.nci.nih.gov/xml/owl/EVS/Thesaurus.owl#C1000013

IRI of the Parent :

http://ncicb.nci.nih.gov/xml/owl/EVS/Thesaurus.owl/C36716

Project is located here (with /) : https://github.com/NCIEVS/nci-protege5/blob/master/data/thesaurus-trimmed-45K-slash.owl.zip

bdionne commented 1 year ago

@singhik

Did you restart? From above:

If you change to / and restart the problem goes away.

The problem is clearly in the IRIs, they are formed with # and not /

singhik commented 1 year ago

@bdionne : Yes, did multiple restarts, cleaned fileprefs, did preference settings and restarted , is there any other setting that needs to be changed ? besides :

image

singhik commented 1 year ago

This is validated in 4.2.0-dev2 client build .