search

NCIEVS / ops-data-conversion

BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Syntax errors in the latest version of CDISC terminologies in OWL #9

Open jindrichmynarz opened 2 years ago

jindrichmynarz commented 2 years ago

The latest versions of CDISC terminologies (from December 17, 2021) in OWL contain syntax errors. The default namespaces of the terminologies and base URIs contain the path to the ODM Converter, for example in ADaM terminology:

xmlns="http://rdf.cdisc.org/c:\ncievs-code\cdisc-reporting-code\ops-data-conversion\odm_converter\in\adam-terminology#"
xml:base="http://rdf.cdisc.org/c:\ncievs-code\cdisc-reporting-code\ops-data-conversion\odm_converter\in\adam-terminology"

The correct URIs should be:

xmlns="http://rdf.cdisc.org/adam-terminology#"
xml:base="http://rdf.cdisc.org/adam-terminology"

This breaks consuming applications, because the backslash separators in the path to ODM Converter are treated as escape characters, for example:

Illegal unicode escape sequence value: \n (0x6E)

The errors appear at least in the ADaM terminology and SDTM terminology. The preceding versions of these terminologies don't contain these syntax errors.

kimong commented 2 years ago

Please test it again.

jindrichmynarz commented 2 years ago

The OWL files on EVS remain containing syntax errors. I haven't run ODM Converter directly, nor do I know how to do so.

kimong commented 2 years ago

The OWL files on EVS have not been updated yet.

akuppusamy-wci commented 2 years ago

This issue used to happen only when the code was run on a Windows based machine. The fix was tested in both Windows and Linux based system. The OWL files created for the next quater would not have this issue.