search

NCIOCPL / NCI.OCPL.Api.Shared

Common code shared between APIs
0 stars 1 forks source link

Reference Elasticsearch 5.6. #10

Closed blairlearn closed 3 years ago

blairlearn commented 3 years ago

Issue description

Change the NCI.OCPL.Api.Common package to reference NEST (Elasticsearch) 5.6.x instead of 7.9

ESTIMATE TBD

What's the expected change?

What's the current functionality?

What's the updated acceptance criteria?

Additional details / screenshot

-

Related Tickets

blairlearn commented 3 years ago

Part of this effort is to revert to an older version of ElasticsearchInterceptingConnection (in NCI.OCPL.Api.Common.Testing) as substantial changes were needed to that class in order to create tests for ES 7.9.

The unit tests for ElasticsearchInterceptingConnection (created as part of #1) reflect some of that refactoring.

Modifying the tests to work with the older version of the class isn't worth the effort since the NuGet packages will move back to supporting the newer version of Elasticsearch shortly after we move to .Net 3.1.

Tests removed are:

blairlearn commented 3 years ago

Closed by 0caee0d1293dc6ff8654e5db252c146123957ddf