search

NCIOCPL / NCI.OCPL.Api.Shared

Common code shared between APIs
0 stars 1 forks source link

NuGet packages not built on push to v2.x branch #36

Closed blairlearn closed 3 years ago

blairlearn commented 3 years ago

Issue description

The NuGet packages are supposed to be built when code is pushed to the "released code" branch (i.e. Any of the released vx.y branches.) This fails to happen for the 2.x branch because the publish_nuget_packages job in the workflow hard-codes the targeted branch to v1.x (i.e. github.ref == 'refs/heads/v1.x' instead of something more general.)

ESTIMATE TBD

Steps to reproduce the issue

Please do NOT test this against the NCIOCPL copy of the NCI.OCPL.Api.Shared repository.

  1. Create a release
  2. Push to the 2.x branch

What's the expected result?

What's the actual result?

Additional details / screenshot

Related Tickets

blairlearn commented 3 years ago

Publishing doesn't deploy, now due to a syntax error in the new code.