NCIOCPL / bestbets-api

0 stars 4 forks source link

Implement deployment health check #17

Closed blairlearn closed 1 year ago

blairlearn commented 7 years ago

The deployment script does not currently check whether the API container is successfully running. This is due a race condition where processing returns to the script after the container is running, but potentially before the API has started.

TODO:

  1. Move the curl logic from deploy-stage.sh into a healthcheck script to be included in the API image.
  2. Modify the Dockerfile to use the HEALTHCHECK directive, specifying the aforementioned healtcheck script.
  3. Check the container's Status property using docker ps --format {{.Status}}
blairl-nih commented 1 year ago

overtaken by events