The integration tests currently reference the loader as a git submodule and load data from a fixed commit. This is fine in theory, but submodules are a bit hacky and seem to have always been second-class citizens in git.
The best bets API should just load data from a static file the same way the other APIs do it.
ESTIMATE TBD
What's the expected change?
Remove the git submodule from the API integration tests
Create a static file containing the test data
Modify the load-integration-data.sh script to load from the data file instead.
What's the current functionality?
The load-integration-data.sh script pulls down the bestbets-loader as a git submodule, overrides the default configuration, and runs the loader.
Issue description
The integration tests currently reference the loader as a git submodule and load data from a fixed commit. This is fine in theory, but submodules are a bit hacky and seem to have always been second-class citizens in git.
The best bets API should just load data from a static file the same way the other APIs do it.
What's the expected change?
load-integration-data.shscript to load from the data file instead.What's the current functionality?
load-integration-data.shscript pulls down the bestbets-loader as a git submodule, overrides the default configuration, and runs the loader.What's the updated acceptance criteria?
Additional details / screenshot
Related Tickets