Closed alifr closed 5 years ago
Acceptance Criteria
<div id="nvcgSlSectionNav">
does not exist in the markup<div id="nvcgSlListBlogRTRail">
is removed from the page <div id="main">
spans the full width of the page<div id="main">
) has a left padding of 1.6em
1em
and left padding of 2.5em
1.5em
and a computed size of 24px
. Note: em units are relative to their parent elements' size, so when stacked they may have different final font size.FDA Approves Two Genomic Profiling Tests for Cancer
aside card. Note: I currently can not find an example of this in the Drupal test site.Hi @alifr -
1.ii : I viewed source and deleted <div id="nvcgSlListBlogRTRail">
from the page, but am not seeing the content span the full width.
Also there seems to be an extra non-breaking space between the end of the main content, above the "older/newer" pager.
I was not able to find a blog post with the additional <p>
tag. That must be a content issue you found. Our templates are not programmatically adding those.
Looks good. Passes review!
There are a couple of content type specific references to Blog pages that will need to be updated when migrating to the Drupal platform where these page hooks no longer exist.
New selectors will have to be used, or hooks added to Drupal content types to get these features working.
#nvcgSlSectionNav
inblogs.scss
is now handled by twig templates..contentzone
inblog.scss
to blogPost entry point scssfigure.image-right-medium
inblogs.scss
to be properly scoped to the blogPost entry point scss file.cgvblogseries .list a.title {
font size styles inbogs.scss
to blogSeries entry point scss.topic-feature .cgvBlogPost a h3
inblue.scss
with.topic-feature .feature-card a h3