search

NCIOCPL / cgov-digital-platform

The Cancer.gov Digital Communications Platform
GNU General Public License v2.0
11 stars 33 forks source link

On CTHP and PDQ pages " - patient" and "- health_professional" are being added into the page name (and then stacking).Technical Item: #2201

Closed welshja closed 5 years ago

welshja commented 5 years ago

Go to any CTHP or PDQ page, looks at the analytics debugger and you will see that the page name is set to a value like "www.cancer.gov/types/liver/hp - health_professional". Click the toggle betwee patient and HP and observe the same. As you go back to the HP page or if you elicit click events on the page, you'll see that the "- patient" or "- health_professional" begin to stack and add multiple times over. This can leave you with values like "www.cancer.gov/types/liver/hp - health_professional - health_professional - health_professional - health_professional - health_professional".

Please fix so that those suffixes are not added into page names for these URLs. We should not see those values at all.

welshja commented 5 years ago

@bryanpizzillo , it looks like this is still open. I thought this got fixed and released? I'm still seeing the issue in production. If it is possible to get this fixed sooner than later that would be much appreciated. It is messing with a lot of our reporting.

It looks like the issue issue was fixed for page names, and I can see that in prod, but it is not fixed on click events that occur on PDQs or CTHPs (like card clicks or on this page clicks for example.)

bryanpizzillo commented 5 years ago

Well, I approved a PR that said it was working and the code was merged. There is code on production that is tied to issue 2201. So I only have to assume the ticket was not thoroughly tested...