NCIOCPL / cgov-digital-platform

The Cancer.gov Digital Communications Platform
GNU General Public License v2.0
11 stars 33 forks source link

CTHP Overview card - random bullet displays when there's more than one paragraph of text #2350

Open lburack opened 5 years ago

lburack commented 5 years ago

On Cancer Type Homepages (CTHPs) that have more than one paragraph of text, there's a random bullet overlapping with a text character in the second paragraph. https://www.cancer.gov/types/bone

Screen Shot 2019-08-23 at 10 21 27 AM

This may be a result of old PDQ Banana Split code. If so, that "pilot" is no longer in flight so any related code could be removed. This is just an IA's hunch and would need to be verified.

Prioritization:

blairlearn commented 5 months ago

This is a styling issue with links appearing in the text.

The markup: image

The CSS rule: image

blairlearn commented 5 months ago

On the surface, this appears to be just a silly bit of CSS putting bullets onto any <a> contained within a <p>.

Digging deeper, it turns out that research card renders a managed list as a series of <p> tags with an <a> as the content.

Fixing this requires reworking docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/templates/content/cancer_research/field--field-selected-research--cthp-research-card.html.twig to output a proper unordered list. Potentially, other card types are also impacted.