NCIOCPL / cgov-digital-platform

The Cancer.gov Digital Communications Platform
GNU General Public License v2.0
11 stars 33 forks source link

Module Update: Admin Toolbar #3120

Closed bryanpizzillo closed 3 years ago

bryanpizzillo commented 3 years ago

Issue description

drupal/admin_toolbar is version 1.27.0, which does not support 9.x. This should be updated to latest version if possible. (2.1 is the first version supporting 9.x, so we are a good ways off the mark from being up to date on this)

ESTIMATE TBD

bkline commented 3 years ago

On the host machine:

composer require drupal/admin_toolbar:^3.0
composer update drupal/admin_toolbar --with-dependencies

In the docker container:

drush updatedb -y
drush cache:rebuild
blt custom:paratest:run
drush pm:list | grep admin_toolbar

Reviewed the admin toolbar and didn't see anything suspicious. I'm not a heavy CMS user, though, so others might pick up on changes I've missed.

bkline commented 3 years ago

Here's what updatedb did:

 --------------------- ----------- --------------- ---------------------------- 
  Module                Update ID   Type            Description                 
 --------------------- ----------- --------------- ---------------------------- 
  admin_toolbar_tools   8001        hook_update_n   Install the Admin Toolbar   
                                                    Search module.              
  admin_toolbar_tools   8201        hook_update_n   Default setting for         
                                                    maximum number of bundles   
                                                    per entity type to          
                                                    display.                    
  admin_toolbar_tools   8202        hook_update_n   Default setting for enable  
                                                    hoverintent.                
 --------------------- ----------- --------------- ---------------------------- 
bryanpizzillo commented 3 years ago

@lburack Blair/Bob found one difference that may affect users.

Old Menu

image

New Menu

image

bkline commented 3 years ago

Add Media is a submenu under Media now.

lburack commented 3 years ago

https://ncigovcdode430.prod.acquia-sites.com/ The inconsistency between Media and Add Content is weird; why can’t they both be Add xxx? But when you hover on Media, you get the ‘Add Media’ fly out. It’s an extra hover, but the intended UX of more quickly selecting the media/content type you want to add to the system remains intact. So that’s good.

Can the order be changed? I’d prefer if Media was below Add Content.

bryanpizzillo commented 3 years ago

The main question is, can you live with this for now? The menu is actually built from the Drupal menus, which as you can see below, Media is the last tab that appears. We could probably swap that in the content menu. TBH, there should probably just be a separate /media url and menu item at the top level outside of Content...

image

lburack commented 3 years ago

@bryanpizzillo - yes, can live with this now. Are you suggesting that we have a Content tab and then a separate Media tab? So we'd have Content | Media | Structure | etc? Not sure that's the best solution, but we can discuss future requirements down the road. For now, can live with this update.

Screen Shot 2021-09-02 at 5 42 50 PM

bryanpizzillo commented 3 years ago

For some reason this did not get automatically closed.