search

NCIOCPL / cgov-digital-platform

The Cancer.gov Digital Communications Platform
GNU General Public License v2.0
11 stars 33 forks source link

Add space above the footer on app module pages #3675

Closed bennettcc closed 1 year ago

bennettcc commented 1 year ago

This item was reported during ACSF-dev testing:

Page elements at the bottom of app module pages are aligning too closely to the page footer - see examples below. Please add padding above the footer on the app module pages to increase the separation between the body content and the footer.

Example link: https://www-dev-acsf.cancer.gov/about-cancer/treatment/clinical-trials/disease/breast-cancer Prod version: https://www.cancer.gov/about-cancer/treatment/clinical-trials/disease/breast-cancer

image

image

App Module Pages that need the updated spacing:

Clinical Trials Search: https://www-dev-acsf.cancer.gov/about-cancer/treatment/clinical-trials/search Dynamic Listing Pages: https://www-dev-acsf.cancer.gov/about-cancer/treatment/clinical-trials/disease/breast-cancer/ Manual Listing Pages: https://www-dev-acsf.cancer.gov/about-cancer/treatment/clinical-trials/covid-19 Dictionary of Cancer Terms: https://www-dev-acsf.cancer.gov/publications/dictionaries/cancer-terms Genetics Dictionary: https://www-dev-acsf.cancer.gov/publications/dictionaries/genetics-dictionary Drug Dictionary: https://www-dev-acsf.cancer.gov/publications/dictionaries/cancer-drug R4R: https://www-dev-acsf.cancer.gov/research/resources

bryanpizzillo commented 1 year ago

@bennettcc what about https://www-dev-acsf.cancer.gov/research/resources

bennettcc commented 1 year ago

Yup @bryanpizzillo @dev-rana-publicis the R4R page is another example. It looks like all the App Module Pages need the additional space except for Sitewide search.

App Module Links:

Clinical Trials Search: https://www-dev-acsf.cancer.gov/about-cancer/treatment/clinical-trials/search Dynamic Listing Pages: https://www-dev-acsf.cancer.gov/about-cancer/treatment/clinical-trials/disease/breast-cancer/ Manual Listing Pages: https://www-dev-acsf.cancer.gov/about-cancer/treatment/clinical-trials/covid-19 Dictionary of Cancer Terms: https://www-dev-acsf.cancer.gov/publications/dictionaries/cancer-terms Genetics Dictionary: https://www-dev-acsf.cancer.gov/publications/dictionaries/genetics-dictionary Drug Dictionary: https://www-dev-acsf.cancer.gov/publications/dictionaries/cancer-drug R4R: https://www-dev-acsf.cancer.gov/research/resources

Search results looks okay to me: Search Results: https://www-dev-acsf.cancer.gov/search/results?swKeyword=cancer