Update code to use R4R as Generic App Module

[bryanpizzillo]

Issue description

ESTIMATE TBD

This is the cgdp peer to https://github.com/NCIOCPL/r4r-app/issues/11. This work should only be committed once production has been updated to use the generic app module.

[!WARNING] The cgov_r4r module must be uninstalled and the app module config for the R4R App modules removed from production before a code deployment missing those items is released. The easiest way is to handle the removal in 2 releases:

• the first to remove the JavaScript, make cgov_r4r templates a no-op, disable and remove configs in cgov_application_page
• the second is to delete the docroot/modules/custom/cgov_r4r folder.

Release 1 Tasks:

[!NOTE] The templates and webpack entry points for cgov_common appear to have been removed previously.

• [ ] Update docroot/profiles/custom/cgov_site/modules/custom/cgov_yaml_content/content/009_app_module_r4r.content.yml to have the new App module config and make sure it works.
• [ ] Remove cgov_r4r from docroot/profiles/custom/cgov_site/cgov_site.info.yml
• [ ] Update the app module template to not reference the r4r-app library. These should change to output no HTML.
  • docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/templates/app_module/r4r/app-module--cgov-r4r-app.html.twig
• [ ] Remove the r4r JS (include entrypoints)
  • [ ] Remove docroot/profiles/custom/cgov_site/themes/custom/cgov/cgov_common/src/libraries/r4r
  • [ ] docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/front-end/src/entrypoints/r4r
  • [ ] Remove the r4r-app from docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/front-end/webpack.entries.js
  • [ ] Remove docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/front-end/local_packages
  • [ ] Remove @nciocpl/r4r-app from the ncids_trans package.json
  • [ ] R4R has a crapton of bad dependencies that should have been in R4R's devDependencies list -- verify they are no longer ncids_trans' dependencies.
  • [ ] Remove cgov/src/analytics/dumb-datalayer.js as it appears that r4r is the last thing using it.
  • [ ] Remove the r4r-app conditional from docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/front-end/postcss.config.js
• [ ] Add an update hook to cgov_application_page that turns off cgov_r4r module and removes the R4R app module config.
• [ ] For warm fuzzies, remove cgov_application_page_update_8004 from cgov_application_page.install leaving a comment that 8004 installed the old cgov_r4r which has been removed
  • We should probably go ahead and remove a lot of the old update hooks... but that is another ticket.

Release 2 Tasks:

• Make a ticket for deleting docroot/modules/custom/cgov_r4r

[bryanpizzillo]

It should be noted that as of 20240916 npm audit shows:

156 vulnerabilities (2 low, 110 moderate, 38 high, 6 critical)

(Many of these should be resolved by r4r's removal from the code base)

[bryanpizzillo]

After removing the R4R package:

19 vulnerabilities (9 moderate, 8 high, 2 critical)

(which is much more manageable to resolve in a separate ticket)