search

NCIOCPL / cgov-digital-platform

The Cancer.gov Digital Communications Platform
GNU General Public License v2.0
11 stars 33 forks source link

We have had intermittent issues in Production where sites become unavailable #4475

Closed bryanpizzillo closed 2 days ago

bryanpizzillo commented 3 weeks ago

Issue description

ESTIMATE TBD

An example of an error we see is:

Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The "paragraph" entity type did not specify a translation handler. in Drupal\Core\Entity\EntityTypeManager->getHandler() (line 262 of /mnt/www/html/ncigov01live/docroot/core/lib/Drupal/Core/Entity/EntityTypeManager.php)

We have many different "gremlins" that seem to occur where the sites just "lose" configuration information. (e.g., fields disappear from content types)

In tracking down the error above we found https://www.drupal.org/project/paragraphs/issues/3031598. The paragraphs team noted this is a core issue, which took us to https://www.drupal.org/project/drupal/issues/3207813#comment-15778426.

It sounds like a true fix for Drupal would be handled in https://www.drupal.org/project/drupal/issues/1905334, but that is a ways away. (Such comments as "we should get rid of .module files" mean it is going to take a lot longer)

Proposed Solution

Let's implement the fix in https://www.drupal.org/project/drupal/issues/3207813#comment-15778426 and try it out and make sure it does not break anything. Hopefully this will resolve the random issues that crop up from time to time in production.

blairlearn commented 3 weeks ago

It appears "the merge request" referenced in that ticket is the one from: https://www.drupal.org/project/drupal/issues/3207813#comment-14962228

blairlearn commented 1 week ago

As noted in comments on #4476, this patch appears to have side-effects.

  1. Edit an article.
  2. Save and republish
  3. Attempting to retrieve the page (even in an incognito window, or via curl) results in a status 404 return.

This can (so far) only be replicated in an ACSF environment. Reviewing the logs reveals no errors; additionally, none of the request logs (access.log, drupal-request, etc) have any record of a 404 status.