(#4484) Add Audio-Described Link to Video Content Type

NCIOCPL / cgov-digital-platform

The Cancer.gov Digital Communications Platform

GNU General Public License v2.0

11 stars 33 forks source link

(#4484) Add Audio-Described Link to Video Content Type #4509

Open dev-rana-publicis opened 5 days ago

dev-rana-publicis commented 5 days ago

Closes #4484 ODE: https://ncigovcdode871.prod.acquia-sites.com/

cgdp-management-server[bot] commented 5 days ago

ODE Deployment

Code has been deployed to ODE 871.

andyvanavery31 commented 5 days ago

Things to update/confirm:

The display options without caption need to have the caption of the video removed, but it still needs the audio-described version to test when there is an AD link but no caption.
Spacing above the audio-described section will match the comps when there is no caption
The audio-described text will be Poppins size 14px to match the legacy caption style. The period will not be hyperlinked, and the wrapping behavior of the external link icon will remain consistent with legacy behavior.

alinai commented 5 days ago

Tool-tip text on ODE does not match the AC:

alinai commented 4 days ago

@andyvanavery31 , please confirm, if we want the text "Audio-Description:" or we want the icon for "Audio-Description:" in front of the link "Watch the audio-described version of this video."?

Also, I could not see any comp with external link. Can you please confirm if it looks good to you on ODE 871?

andyvanavery31 commented 4 days ago

@andyvanavery31 , please confirm, if we want the text "Audio-Description:" or we want the icon for "Audio-Description:" in front of the link "Watch the audio-described version of this video."?

Also, I could not see any comp with external link. Can you please confirm if it looks good to you on ODE 871?

@alinai The late change request from Alex is to use the icon followed by "Watch the audio-described version of this video." I updated the AC's to match this, and also added the Spanish version for testing too. Additionally, the external link icon appears due to legacy behavior and was not accounted for in the comp. This behavior is correct, and I added a note to confirm that in the ticket.

Cc: @dev-rana-publicis

dev-rana-publicis commented 4 days ago

11/22 Push Fixes:

Fixed test scenarios. We now have 4 test pages to test the audio-described link and other variations with the caption and audio-described link in English
- Also added two Spanish test pages
Spacing is fixed for when there is an audio-described link but no caption
Changed audio-described link font-size to be 14px

andyvanavery31 commented 1 day ago

When there is no caption and only the AD link text, the total top spacing is 3.625px instead of 8px due to the -4.375px margin. Can this be removed?
The tooltip text isn't appearing correctly

dev-rana-publicis commented 1 day ago

11/25 Push Fixes:

Fixed spacing on AD link when there is no caption
Tooltip text is now showing the expected text