search

NCIOCPL / clinical-trials-search-app

Clinical Trial Search Front-end
1 stars 6 forks source link

Trial Details location filter does not handle US territories except Puerto Rico. #226

Closed blairlearn closed 2 years ago

blairlearn commented 3 years ago

Issue description

Trials have started being reported in Guam (a territory). This results in the location filter on the trial details page displaying a blank line in a random location.

This appears to happen because the state list in src/utilities/getStateNameFromAbbr.js doesn't include any territories other than Puerto Rico.

ESTIMATE 2

Steps to reproduce the issue

  1. Navigate to the details page for a trial with sites in a territory other than Puerto Rico. (As of this writing, NCT02201992 has sites in Guam. So.. https://www.cancer.gov/about-cancer/treatment/clinical-trials/search/v?id=NCI-2014-01507&loc=0&rl=1)
  2. Expand the "Locations and Contacts" accordion.
  3. Expand the "State" dropdown

What's the expected result?

What's the actual result?

Additional details / screenshot

Related Tickets

blairlearn commented 3 years ago

NOTE: In addition to the problem with src/utilities/getStateNameFromAbbr.js, the list in src/utilities/stateUtils.js also omits territories. It's not immediately clear whether it's deliberately "states-only" or if this is also an oversight. (Though in the latter case, why are there two lists?)

alerosad commented 2 years ago

I don't see the mentioned bug

Screen Shot 2022-04-25 at 1 33 10 PM
alerosad commented 2 years ago

I checked the feature branch too, and didn't see this issue come up on the example you provided Blair

alerosad commented 2 years ago

Both Develop and feature seem to not have this issue

KateMashkinaNIH commented 2 years ago

this was fixed