search

NCIOCPL / clinical-trials-search-app

Clinical Trial Search Front-end
1 stars 6 forks source link

Search results page does not return correct result on clicking "Modify Search Criteria" link after different page is selected from the pager #517

Closed alinai closed 2 years ago

alinai commented 2 years ago

Issue description

When we select a Trial Type from Advanced Search page and then perform search, then if we select a different page number from the pager and then select " "Modify Search Criteria" link and select Trial Phase=IV and perform search again we see three different behaviors in three environments - Prod, local host, https://react-app-dev.cancer.gov/clinical-trials-search-app/pr-515.

ESTIMATE TBD

Steps to reproduce the issue

  1. Go to the Advanced Search page on local host or https://react-app-dev.cancer.gov/clinical-trials-search-app/pr-515 or Prod
  2. Select Trial Type= Other
  3. Perform the search by clicking the "Find Trials" button.
  4. Select page No=75 from the pager.
  5. Click the "Modify Search Criteria"
  6. Select Trial Phase= IV
  7. Perform the search by clicking the "Find Trials" button.
  8. We get an error page on react-app-dev (screen-shot is attached) and results are not loaded on local host (screen-shot is attached). Prod returns a blank search results page with "Results 741-5 of 5 for your search" (screen-shot is attached)

What's the expected result?

What's the actual result?

Additional details / screenshot

image

image

image

Related Tickets

alerosad commented 2 years ago

on localhost I received the same error page as react-app-dev, however, prod is different like you mentioned

image
alinai commented 2 years ago

@sarinapadilla , can you please confirm the requirement for this ticket? I thought "Search Results page should return correct results" is what we expect but want to confirm with you. Thanks!! cc: @alerosad

sarinapadilla commented 2 years ago

@alinai @alerosad let's wait to re-confirm if this is an issue (and what the steps to recreate are) after we've merged the cts-api-v2-transition branch into develop.

alinai commented 2 years ago

@alinai @alerosad let's wait to re-confirm if this is an issue (and what the steps to recreate are) after we've merged the cts-api-v2-transition branch into develop.

Thanks @sarinapadilla

seyilonge-nci commented 2 years ago

@alinai @sarinapadilla This is no longer an issue as the error page is now displayed with No clinical trials matched your search. Page 75 is invalid. message.

As shown in the screenshot below.

Screen Shot 2022-07-01 at 10 10 19 AM

@sarinapadilla we can close this.

sarinapadilla commented 2 years ago

See @seyilonge-nci's comment above. Closing this ticket!