search

NCIOCPL / clinical-trials-search-app

Clinical Trial Search Front-end
1 stars 6 forks source link

(#567) Hospital/Institution invalid params page loads scrolled to the bottom of the page #584

Open alerosad opened 1 year ago

alerosad commented 1 year ago

Closes #567

alerosad commented 1 year ago

https://react-app-dev.cancer.gov/clinical-trials-search-app/pr-584

alinai commented 1 year ago

@alerosad , this looks good to me. Noticing that the text in "Have a Question" delighter is wrapping to three lines instead of two lines in Prod. I checked the develop branch and the same issue exits in the develop branch. Just want to make sure that the text wrapping issue will not propagate to Prod. cc: @sarinapadilla , @KateMashkinaNIH

image image

alerosad commented 1 year ago

@alerosad , this looks good to me. Noticing that the text in "Have a Question" delighter is wrapping to three lines instead of two lines in Prod. I checked the develop branch and the same issue exits in the develop branch. Just want to make sure that the text wrapping issue will not propagate to Prod. cc: @sarinapadilla , @KateMashkinaNIH

image image

not sure, seems to be an issue that will need to be addressed in a future ticket

kate-mashkina commented 1 year ago

cts app on dev-ac is pointed to react-app develop branch and the wrapping of the delighter's text is a non-issue. We can safely say that this will not be an issue on upper tiers @alinai