NCIOCPL / clinical-trials-search-print

Print service for clinical trial search
0 stars 1 forks source link

State is not appearing in Search Criteria box #75

Closed sarinapadilla closed 1 year ago

sarinapadilla commented 1 year ago

Issue description

If you use a US state as part of your search criteria, then select a trial to print, the state parameter and name are not displaying in the Search Criteria box.

ESTIMATE TBD

Steps to reproduce the issue

  1. Go to https://ncigovcdode450.prod.acquia-sites.com/about-cancer/treatment/clinical-trials/search/r?lcnty=United%20States&loc=2&lst=AL&rl=2
  2. Select a trial
  3. Print

What's the expected result?

What's the actual result?

Additional details / screenshot

Related Tickets

blairlearn commented 1 year ago

This is due to an ambiguity in the specification for the list of states.

CTS.Print is expecting a list of state codes as with the previous implementation. What's being passed is a list of objects with both an abbreviation and a name.

blairlearn commented 1 year ago

The workaround/quick fix is to parse out just the state abbreviations and ignore the rest of the structure. This feels somewhat dirty, but in addition to preserving the existing code, also removes the need to sanitize the full names.

alinai commented 1 year ago

@blairlearn , @sarinapadilla , "Other treatments" also does NOT display in the Search Criteria box on the Print page. Steps to reproduce:

  1. Go to https://ncigovcdode450.prod.acquia-sites.com/about-cancer/treatment/clinical-trials/search/r?d=C471&i=C16032&lcnty=United%20States&loc=2&lst=AK&rl=2
  2. Select a trial
  3. Print.
  4. See that the Search Criteria box on the Print page does not display "Other treatments"
alinai commented 1 year ago

Both "state" and "other treatments" are appearing on the Print page on blue. Thanks @blairlearn

image

sarinapadilla commented 1 year ago

This looks good to me!