Closed blairlearn closed 4 years ago
These two items should not be modified as their paths are already URL safe (e.g. /drugs/12334 or /drugs/my-drug)
Also DrugsController::Expand because the value for the expansion should not be an issue...?
Per team discussion, Expand
, GetById
and GetByName
will continue to get parameters via the path. Only Autosuggest and Search will be updated to query string params. This will be consistent with the Glossary API.
Issue description
Based on lessons learned from the sitewide-search and bestbets APIs and others, we should change the Autosuggest and Drugs controllers to retrieve their search inputs as query parameters instead of path segments. (Path segments are cool, but they run into problems with search items such as
/
,bin
, '2/3` and so forth.)What's the expected change?
searchText
a query string parameter.character
a query string parameter.~id
a query string parameter.~prettyUrlName
a query string parameter.~query
a query string parameter.In addition to the controllers, the integration tests will need to be updated to move the parameter from the path to the params list.
What's the current functionality?
-
What's the updated acceptance criteria?
Additional details / screenshot
Related Tickets