NCIOCPL / drug-dictionary-api

NCI Drug Dictionary API
0 stars 3 forks source link

Change path parameters to query string parameters #26

Closed blairlearn closed 4 years ago

blairlearn commented 4 years ago

Issue description

Based on lessons learned from the sitewide-search and bestbets APIs and others, we should change the Autosuggest and Drugs controllers to retrieve their search inputs as query parameters instead of path segments. (Path segments are cool, but they run into problems with search items such as /, bin, '2/3` and so forth.)

ESTIMATE 20

What's the expected change?

In addition to the controllers, the integration tests will need to be updated to move the parameter from the path to the params list.

What's the current functionality?

-

What's the updated acceptance criteria?

Additional details / screenshot

Related Tickets

bryanpizzillo commented 4 years ago

These two items should not be modified as their paths are already URL safe (e.g. /drugs/12334 or /drugs/my-drug)

Also DrugsController::Expand because the value for the expansion should not be an issue...?

blairlearn commented 4 years ago

Per team discussion, Expand, GetById and GetByName will continue to get parameters via the path. Only Autosuggest and Search will be updated to query string params. This will be consistent with the Glossary API.