search

NCIOCPL / drug-dictionary-api

NCI Drug Dictionary API
0 stars 3 forks source link

Searching for '/' query is not working #27

Closed kate-mashkina closed 4 years ago

kate-mashkina commented 4 years ago

Issue description

The API is not returning correct results when searching with a query containing /

ESTIMATE 20

Steps to reproduce the issue

  1. on cancer gov Drug Dictionary search for /cd40 with contains
  2. There are two results returned that contain /CD40
  3. Execute /Drugs/search/{query} with '/cd40' matchType 'Contains' in Swagger
  4. There are 23 results returned that are matched against just CD40 (without appended /)

What's the expected result?

What's the actual result?

Additional details / screenshot

Screen Shot 2020-08-19 at 1 50 34 PM Screen Shot 2020-08-19 at 1 51 04 PM

Related Tickets

blairlearn commented 4 years ago

This is likely related to NCIOCPL/bestbets-api#34.

It will likely be corrected by replacing path parameters with query string parameters #26

KateMashkinaNIH commented 4 years ago

Tested PR #30 - this issue is resolved by it

blairlearn commented 4 years ago

Resolved by #30. Closing manually.