NCIOCPL / gatsby-pcp

President's Cancer Panel website
https://prescancerpanel.cancer.gov
2 stars 0 forks source link

Simplify image inclusion and styles #227

Closed jfrank-nih closed 2 weeks ago

jfrank-nih commented 1 year ago

Issue description

We currently have multiple different image inclusion methods.

I'd like to simplify this to:

We'll create a documentation page on how to use them in combination with each other to get the results we want. Changes we make should look substantially similar to current formats but don't have to be identical.

We should also move off of gatsby-image, which is deprecated, to gatsby-plugin-image. See also #219.

What's the proposed change?

erikscottmeyer commented 1 year ago

responsive-image: No real way to replicate this with other tags leave as-is. But are we able to remove the

around it without introducing any problems? Yes, it seems to work fine. Just did that locally.

erikscottmeyer commented 1 year ago

image-with-caption: these changes should be fine

erikscottmeyer commented 1 year ago

image-with-class: I'd say use the second option (pdate to have the className attribute but instead of src and alt it would just wrap around the standard markdown syntax. )

erikscottmeyer commented 1 year ago

picture-with-quotes : we could rig something like this up; obviously it would be easier if we didn't need it to replicate what this does and simplified rendering

jfrank-nih commented 2 weeks ago

Closing because PCP has moved to the digital platform.