(#143) Fix title- vs. lower-case in fallback logic

NCIOCPL / glossary-api

API for Dictionary of Cancer Terms, Dictionary of Genetics Terms, and other Glossary documents.

0 stars 5 forks source link

(#143) Fix title- vs. lower-case in fallback logic #144

Closed sarinapadilla closed 3 years ago

sarinapadilla commented 3 years ago

Update fallback logic to lowercase dictionary param
Update fallback combinations to use lowercase dictionary param
Update GetById tests for lower- and title-case params
Update GetByName tests for lower- and title-case params
Update integration tests to account for lower- and title-case params

blairlearn commented 3 years ago

@sarinapadilla and I have discovered that the Elasticsearch mapping for the dictionary field needs to be changed to use the caseinsensitive_normalizer.

                "dictionary": {
                    "type": "keyword",
                    "normalizer": "caseinsensitive_normalizer"
                },

@bkline, please make this change in the glossary loader and push it to the DEV tier.

bkline commented 3 years ago

I have reloaded ncias-d2433-v using the requested modification to the mapping file.