GetById returns status 500 for nonexistent IDs

[blairlearn]

Issue description

When a glossary term is requested by ID, and no term matches that ID, the API returns an HTTP status 500 instead of 404.

This appears to be due to a change in the NEST client between versions 5.x and 7.x, whereby response.IsValid is now false when the term is not found.

As part of fixing this issue, it will be necessary to review the unit tests and verify that all methods are tested for appropriate behaviors when Elasticsearch returns a non-200 status.

ESTIMATE TBD

Steps to reproduce the issue

1. Spin up the Docker containers in the integration-tests/docker-glossary-api directory.
2. Browse to http://localhost:5000/Terms/cancer.gov/Patient/en/5 or use the swagger page to achieve the same.

What's the expected result?

• Status 404
• Message {"Message":"No match for dictionary 'cancer.gov', audience 'Patient', language 'en' and id '5."}

What's the actual result?

• Status 500
• Message: {"Message":"Invalid response when searching for dictionary 'cancer.gov', audience 'Patient', language 'en' and id '5."}

Additional details / screenshot

Related Tickets

• Issue #151

[blairlearn]

Fixed in fc16d09b04529138ec19ddda812634fa4478d5ba