NCIOCPL / ncids

NCI Design System
7 stars 5 forks source link

Foundations subpage: Color #1190

Closed sarinapadilla closed 8 months ago

sarinapadilla commented 10 months ago

Update the Color page within the Foundations section of the documentation site with the content needed for NCIDS for All pilot launch.

Tasks

Resources

Doc Site Content Inventory

monika-jaeger commented 10 months ago

Color word doc has been started. This page likely will not need static images, the full color tables for State, Theme, and Color tokens should be on the Color page for ticket https://github.com/NCIOCPL/ncids/issues/1198

cc: @blilianyu @laurelthrash

bennettcc commented 9 months ago

@karlikpj the markdown for Color page is complete, it lives here: https://nih.sharepoint.com/:t:/r/sites/NCI-OCPLNewCgovUXDesignSystem/Shared%20Documents/General/Details%20-%20NCIDS%20Pilot/Documentation%20Site/Page%20Content%20-%20Markdown/Color_markdown.txt?csf=1&web=1&e=twGEo2

FYI, the tables that should be pulled in are currently displaying at the links below (adding in case they don't appear correctly in the new markdown)

State Tokens table: https://designsystem-dev.cancer.gov/develop/foundation/appearance/state-tokens

Theme Tokens table: https://designsystem-dev.cancer.gov/develop/foundation/appearance/theme-tokens

System Tokens table: https://designsystem-dev.cancer.gov/develop/foundation/appearance/system-tokens

laurelthrash commented 9 months ago

@karlikpj - On the Theme tokens table, it should be 'base-darkest; instead of 'base-darktest' - we found a typo on current table. Can we please make this adjustment? Thank you! @bennettcc

bennettcc commented 9 months ago

Thanks @laurelthrash @karlikpj! I just updated the markdown with that correction

bryanpizzillo commented 9 months ago

@sarinapadilla and @andyvanavery31 - we will need a ticket that will be done before this one to:

  1. Disable USWDS colors from the $tokens-color-basic. The NCIDS colors that exist today should stay. This generated the "Basic palette" colors on any foundation page that has colors.

The NCIDS colors defined today are: