GitHub Discussions Review

[laurelthrash]

Description: We have a number of GH Discussion topics (https://github.com/NCIOCPL/ncids/discussions) that have been recorded following various testing for Redesign. This task is for designers to take a pass through this list and aggregate feedback/comments/recommendations on those that relate to design elements.

Sub-tasks:

• [x] Review list of GH Discussions to identify which may have a design impact or are design focused
  • Exclude GH Discussions for which we already discussed in a Requirements meeting (see Canvas notes for this list)
• [x] Catalogue feedback/comments/recommendations by commenting on the GH Discussion directly
• [ ] Share out

[blilianyu]

@laurelthrash I've grouped the discussions below. We can share this out at our Tues/Thurs UX meetings. cc: @monika-jaeger @andyvanavery31 @sarinapadilla

Design Updates

Note: @monika-jaeger is creating updated images

• 1370 [Discussed UX meeting 04/04 - Agreed to adopt change, notified Anna as FYI]

  • Update promo blocks to be Annual Plan image and content
  • Update all content on Promo Block page to be "Professional Judgment Budget Proposal" instead of "Annual Plan"

  • 1672 ✅

• 1372 [Discussed UX meeting 04/04 - Agreed to adopt change, notified Anna as FYI]

  • Update 2-guide card row pattern image

  • 1641 ✅

Content Updates

• 1602 [Discussed UX meeting 04/18 - Adriana provide updated language. Proceeding with update.]

  • 1670 ✅

• 1603 [Discussed UX meeting 04/18 - Adriana provided updated language. Proceeding with update.]

  • 1671 ✅

Confirm Resolution

• 1373 [Discussed UX meeting 04/23 - resolved]

• 1374 [Discussed UX meeting 04/23 - resolved]

• 1377 [Discussed during UX meeting - resolved]

• 1379 [Discussed during UX meeting - resolved]

To be discussed at a later time

Design Discussions Needed

• 1444 [Discussed UX meeting 04/04 - Needs more discussion]

  • Provided recommendations. Will need to discuss as a team

• 1604

  • Will need to discuss with Anna if we want DS to have the option of having no hero image for Home & Landing pages

• 1445

  • Raw HTML Guide Card Row created (#4253) and will be testing out on a landing page and based on analytics will update guidance

Content Discussions Needed

• 1371

• 1376

• 1378

• 1419

• 1420

• 1488

[laurelthrash]

Added to 04/04 meeting for review/discussion.

[adrianacastaneda]

@blilianyu @lburack @laurelthrash Included two options for the Banner component page description below.

Not sure if we want to keep it broad and say "all federal websites" because I'm not sure if this is true... So it seems like we could just say that this is required for all websites under NCI. Let me know your thoughts. Thanks!

1. A banner used to identify official websites of government organizations in the United States. It allows users to know if a website is both official and secure. This component is required for all NCI informational websites and applications.
2. A banner used to identify official websites of government organizations in the United States. It allows users to know if a website is both official and secure. This component is required for all federal websites.

[blilianyu]

@adrianacastaneda I prefer Option 1!

[lburack]

@adrianacastaneda - USWDS says "most government sites should use the banner." https://designsystem.digital.gov/components/banner/ I don't know if it's mandatory for all federal websites so I think option 1 is your safer bet!

[laurelthrash]

We chose to review the discussions that were immediately actionable. These included discussion items under Design Updates, Content Updates, and Confirm Resolution. All of these discussions have either been closed or have a CR created to initiate a solution.

@andyvanavery31 @sarinapadilla - I propose we close this ticket for the time being as all discussions have received design input. Any concerns with this? All remaining discussion items listed above that are open require further discussion. These discussions include Lilian and Monika's feedback directly on the discussion item so feedback can be discussed in context when the item is picked back up in the future.

Cc: @blilianyu @monika-jaeger

[laurelthrash]

@andyvanavery31 @sarinapadilla following up on the above - are you comfortable closing out this ticket for now?

[laurelthrash]

Conferred with @andyvanavery31 @sarinapadilla offline. We will proceed with closing this ticket. All remaining open GH Discussions listed in the description of this ticket contain Lilian and Monika's feedback, to be considered at a later time and tracked via the GH Discussion item. Cc: @blilianyu @monika-jaeger