search

NCIOCPL / ncids

NCI Design System
10 stars 5 forks source link

Regression images differ local vs workflow #1647

Open olitharp-nci opened 5 months ago

olitharp-nci commented 5 months ago

Regressions fail locally when using background icons. Regressions are not failing in the workflow. This has been tested on Intel and M2 (M1 is still hanging while running locally).

Locally, when running regression tests:

Screenshot 2024-04-11 at 11 48 47 AM 
// Storybook CSS on develop:
ul.nci-cta-strip li .usa-button::after {
    display: inline-block;
    height: 2ex;
    width: 2ex;
    background: none;
    background-color: currentColor;
    -webkit-mask: url(static/media/navigate_next.84649ddd.svg) no-repeat center / contain;
    mask: url(static/media/navigate_next.84649ddd.svg) no-repeat center / contain;
    content: "";
    vertical-align: top;
    margin-left: 1px;
// Storybook css on localhost:
ul.nci-cta-strip li .usa-button::after {
    display: inline-block;
    height: 2ex;
    width: 2ex;
    background: none;
    background-color: currentColor;
    mask: url(static/media/_/_/packages/ncids-css/uswds-img/usa-icons/navigate_next.svg) no-repeat center / contain;
    content: "";
    vertical-align: top;
    margin-left: 1px;
}
sarinapadilla commented 1 month ago

This should be looked at in conjunction with #989.