(#1761) Update 'Applying other utilities' paragraph on Figma Guide

monika-jaeger commented 3 months ago

Closes #1761

Pull Request Details

This updates the copy on the doc site on the Figma Guide page under the (former) paragraph heading "Applying other utilities that are not added to the NCIDS Design Kit library" to add more clarity that border, border radius and outline are utilities that can only be referenced in Figma, especially when linking from other areas in the doc site.

Note: The heading is now "Border, Border Radius and Outline Utilities"

Closes ##1761

Author PR Checklist

Items that the author of the PR is responsible for checking before submitted the PR.

General:

[x] I have reviewed the acceptance criteria defined in the ticket and ensured the work has been completed.
[x] The commit message passes all quality commit message standards.
[x] Unit tests have been updated or created to reflect any javascript changes.
[x] Storybook scenarios have been updated or created to reflect any html/css/js changes.

Accessibility:

[ ] WCAG 2.1 Level AA requirements have been met.

Development:

[ ] Any new or updated javascript code has 100% unit test coverage.
[ ] New or updated breakpoints have regression images.
[ ] Breaking changes have been thoroughly documented in the PR.

Product Reviewer PR Checklist

Items the product team is responsible for reviewing.

General:

[ ] There are no unexpected or unapproved regression image changes. 
[ ] Functionality of interactive elements meet the acceptance criteria.
[ ] The product is visually and functionally the same across the different browsers.

Accessibility:

[ ] AxeDev Tools: there are no new or outstanding accessibility issues introduced in this PR.
[ ] Lighthouse: scores have not noticeably decreased during this PR.
[ ] Wave: there are no new errors or contrast errors introduced in this PR.

Design Reviewer PR Checklist

Items the design team is responsible for reviewing.  

General:

[x] New or updated features introduced in this PR are developed mobile-first.
[x] Breakpoint changes and regression images match those breakpoints.
[x] This PR has been tested in all supported browsers at all breakpoints.

Developer Reviewer PR Checklist

Items the development team is responsible for reviewing.

General:

[ ] New code passes code quality standards set by industry standards.
[ ] The expected Storybook stories have been added or updated for the new or updated feature.
[ ] The expected unit tests have been added or updated for the new or updated feature.

Accessibility:

[ ] VoiceOver: Described content matches with what was expected.
[ ] Keyboard navigation: new or updated features and content are navigable via the keyboard.

github-actions[bot] commented 3 months ago

Viewing Information

blilianyu commented 3 months ago

@monika-jaeger can you change the link for "Token & Utilities" to the permalink https://www.figma.com/design/4FeMfprVErO6esR8FLczp5/NCIDS-Design-Kit?node-id=3917-6868&t=YVntX6mh1NZavZkA-1?

monika-jaeger commented 3 months ago

@blilianyu updated the link for Tokens and Utilities, and set privacy settings to Anyone in the Figma Community File. Ready for re-review!

blilianyu commented 3 months ago

@monika-jaeger Looks great, thank you!!

NCIOCPL / ncids